diff options
| author | Jeremy Cline <jcline@redhat.com> | 2018-06-01 16:05:32 -0400 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2018-06-04 09:31:39 +0200 |
| commit | 889ad63d41eea20184b0483e7e585e5b20fb6cfe (patch) | |
| tree | 3ba6dd6621a23c7f944c1e134ac7ab021da32d07 /drivers/gpu/drm/qxl/qxl_cmd.c | |
| parent | c32048d9e93a5ab925d745396c63e7b912147f0a (diff) | |
drm/qxl: Call qxl_bo_unref outside atomic context
"qxl_bo_unref" may sleep, but calling "qxl_release_map" causes
"preempt_disable()" to be called and "preempt_enable()" isn't called
until "qxl_release_unmap" is used. Move the call to "qxl_bo_unref" out
from in between the two to avoid sleeping from an atomic context.
This issue can be demonstrated on a kernel with CONFIG_LOCKDEP=y by
creating a VM using QXL, using a desktop environment using Xorg, then
moving the cursor on or off a window.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1571128
Fixes: 9428088c90b6 ("drm/qxl: reapply cursor after resetting primary")
Cc: stable@vger.kernel.org
Signed-off-by: Jeremy Cline <jcline@redhat.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20180601200532.13619-1-jcline@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/qxl/qxl_cmd.c')
0 files changed, 0 insertions, 0 deletions