diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-07-19 12:47:22 +0300 |
|---|---|---|
| committer | Zack Rusin <zackr@vmware.com> | 2022-08-04 11:27:50 -0400 |
| commit | ffb6260be81f5f4c97b34430072bf50380b42478 (patch) | |
| tree | ff2f58ea3e3287be2a2db4901574db0278b02ba8 /drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | |
| parent | 37c7c23a6420f56a66d70e30ed54ae8f77349f90 (diff) | |
drm/vmwgfx: clean up some error pointer checking
The vmw_user_bo_noref_lookup() function cannot return NULL. If it
could, then this function would return PTR_ERR(NULL) which is success.
Returning success without initializing "*vmw_bo_p = vmw_bo;" would
lead to an uninitialized variable bug in the caller. Smatch complains
about this:
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:1177 vmw_translate_mob_ptr() warn: passing zero to 'PTR_ERR'
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:1314 vmw_cmd_dx_bind_query() error: uninitialized symbol 'vmw_bo'.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/YtZ9qrKeBqmmK8Hv@kili
Diffstat (limited to 'drivers/gpu/drm/vmwgfx/vmwgfx_resource.c')
0 files changed, 0 insertions, 0 deletions