diff options
author | David Mosberger-Tang <davidm@egauge.net> | 2021-12-07 00:26:01 +0000 |
---|---|---|
committer | Kalle Valo <kvalo@kernel.org> | 2021-12-14 20:43:47 +0200 |
commit | dde02213fa64ac7f99eb65cd51f9e04812d8bc40 (patch) | |
tree | 2e21c41e6493f78e7589f0174f278f9049e04f7a /drivers/hwmon/max1619.c | |
parent | 5ae660641db824ecc9c7a49546dff701c6dc7ca7 (diff) |
wilc1000: Remove misleading USE_SPI_DMA macro
The USE_SPI_DMA macro name suggests that it could be set to 1 to
control whether or not SPI DMA should be used. However, that's not
what it does. If set to 1, it'll set the SPI messages'
"is_dma_mapped" flag to true, even though the tx/rx buffers aren't
actually DMA mapped by the driver. In other words, setting this flag
to 1 will break the driver.
Best to clean up this confusion by removing the macro altogether.
There is no need to explicitly initialize "is_dma_mapped" because the
message is cleared to zero anyhow, so "is_dma_mapped" is set to false
by default.
Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
Acked-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20211207002453.3193737-1-davidm@egauge.net
Diffstat (limited to 'drivers/hwmon/max1619.c')
0 files changed, 0 insertions, 0 deletions