diff options
| author | Bernard Metzler <bmt@zurich.ibm.com> | 2022-09-20 10:25:03 +0200 |
|---|---|---|
| committer | Leon Romanovsky <leon@kernel.org> | 2022-09-20 21:23:52 +0300 |
| commit | a3c278807a459e6f50afee6971cabe74cccfb490 (patch) | |
| tree | e00a8456e4073ddf394684609a74a827b72bd719 /drivers/infiniband/sw/siw/siw.h | |
| parent | 754209850df8367c954ac1de7671c7430b1f342c (diff) | |
RDMA/siw: Fix QP destroy to wait for all references dropped.
Delay QP destroy completion until all siw references to QP are
dropped. The calling RDMA core will free QP structure after
successful return from siw_qp_destroy() call, so siw must not
hold any remaining reference to the QP upon return.
A use-after-free was encountered in xfstest generic/460, while
testing NFSoRDMA. Here, after a TCP connection drop by peer,
the triggered siw_cm_work_handler got delayed until after
QP destroy call, referencing a QP which has already freed.
Fixes: 303ae1cdfdf7 ("rdma/siw: application interface")
Reported-by: Olga Kornievskaia <kolga@netapp.com>
Signed-off-by: Bernard Metzler <bmt@zurich.ibm.com>
Link: https://lore.kernel.org/r/20220920082503.224189-1-bmt@zurich.ibm.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Diffstat (limited to 'drivers/infiniband/sw/siw/siw.h')
| -rw-r--r-- | drivers/infiniband/sw/siw/siw.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/infiniband/sw/siw/siw.h b/drivers/infiniband/sw/siw/siw.h index df03d84c6868..2f3a9cda3850 100644 --- a/drivers/infiniband/sw/siw/siw.h +++ b/drivers/infiniband/sw/siw/siw.h @@ -418,6 +418,7 @@ struct siw_qp { struct ib_qp base_qp; struct siw_device *sdev; struct kref ref; + struct completion qp_free; struct list_head devq; int tx_cpu; struct siw_qp_attrs attrs; |