summaryrefslogtreecommitdiff
path: root/drivers/infiniband
diff options
context:
space:
mode:
authorDaniel Jurgens <danielj@mellanox.com>2017-07-05 16:15:21 +0300
committerJames Morris <james.l.morris@oracle.com>2017-07-07 09:49:26 +1000
commita750cfde1397dbbee1efe7737c2e952d6fc2d878 (patch)
treed567ec6ccc997c90a20ab1cf55cc2c15efb8cd1d /drivers/infiniband
parent79d0636ac7f839d57680305a462f0d8ff9bb13ec (diff)
IB/core: Fix static analysis warning in ib_policy_change_task
ib_get_cached_subnet_prefix can technically fail, but the only way it could is not possible based on the loop conditions. Check the return value before using the variable sp to resolve a static analysis warning. -v1: - Fix check to !ret. Paul Moore Fixes: 8f408ab64be6 ("selinux lsm IB/core: Implement LSM notification system") Signed-off-by: Daniel Jurgens <danielj@mellanox.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Paul Moore <paul@paul-moore.com> Signed-off-by: James Morris <james.l.morris@oracle.com>
Diffstat (limited to 'drivers/infiniband')
-rw-r--r--drivers/infiniband/core/device.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 631eaa9daf65..a5dfab6adf49 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -376,7 +376,8 @@ static void ib_policy_change_task(struct work_struct *work)
WARN_ONCE(ret,
"ib_get_cached_subnet_prefix err: %d, this should never happen here\n",
ret);
- ib_security_cache_change(dev, i, sp);
+ if (!ret)
+ ib_security_cache_change(dev, i, sp);
}
}
up_read(&lists_rwsem);