summaryrefslogtreecommitdiff
path: root/drivers/iommu/sprd-iommu.c
diff options
context:
space:
mode:
authorRobin Murphy <robin.murphy@arm.com>2021-04-01 14:56:26 +0100
committerJoerg Roedel <jroedel@suse.de>2021-04-16 17:20:45 +0200
commit2d471b20c55e13c98d1dba413bf2de618e89cdac (patch)
treefe16cf7ce737c7c60d0cd414199cab0bfb4aea47 /drivers/iommu/sprd-iommu.c
parentc0aec6680b6c82fe893a546e322e1130cd5cf21e (diff)
iommu: Streamline registration interface
Rather than have separate opaque setter functions that are easy to overlook and lead to repetitive boilerplate in drivers, let's pass the relevant initialisation parameters directly to iommu_device_register(). Acked-by: Will Deacon <will@kernel.org> Signed-off-by: Robin Murphy <robin.murphy@arm.com> Link: https://lore.kernel.org/r/ab001b87c533b6f4db71eb90db6f888953986c36.1617285386.git.robin.murphy@arm.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu/sprd-iommu.c')
-rw-r--r--drivers/iommu/sprd-iommu.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/iommu/sprd-iommu.c b/drivers/iommu/sprd-iommu.c
index 89272f9fd8f3..73dfd9946312 100644
--- a/drivers/iommu/sprd-iommu.c
+++ b/drivers/iommu/sprd-iommu.c
@@ -508,10 +508,7 @@ static int sprd_iommu_probe(struct platform_device *pdev)
if (ret)
goto put_group;
- iommu_device_set_ops(&sdev->iommu, &sprd_iommu_ops);
- iommu_device_set_fwnode(&sdev->iommu, &dev->of_node->fwnode);
-
- ret = iommu_device_register(&sdev->iommu);
+ ret = iommu_device_register(&sdev->iommu, &sprd_iommu_ops, dev);
if (ret)
goto remove_sysfs;