diff options
| author | Sakari Ailus <sakari.ailus@linux.intel.com> | 2023-12-06 19:25:07 +0200 |
|---|---|---|
| committer | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2023-12-08 10:04:12 +0100 |
| commit | e55a9482888da73eeadde5f13ef8bafce68a38ed (patch) | |
| tree | 7d068e5b0ee3f70819e5ad0c676fb0ab3248535c /drivers/media/i2c/ov9640.c | |
| parent | 843750fb85fda6111c78e5c40e5ca5bc7dde6d10 (diff) | |
media: ov9640: Don't set format in sub-device state
For the purpose of setting old non-pad based sub-device try format as a
basis for VIDIOC_TRY_FMT implementation, there is no need to set the
format in the sub-device state. Drop the assignment to the state, which
would result in a NULL pointer dereference.
Fixes: fd17e3a9a788 ("media: i2c: Use accessors for pad config 'try_*' fields")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Diffstat (limited to 'drivers/media/i2c/ov9640.c')
| -rw-r--r-- | drivers/media/i2c/ov9640.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/media/i2c/ov9640.c b/drivers/media/i2c/ov9640.c index b0c171fe75bc..e9a52a8a9dc0 100644 --- a/drivers/media/i2c/ov9640.c +++ b/drivers/media/i2c/ov9640.c @@ -547,8 +547,6 @@ static int ov9640_set_fmt(struct v4l2_subdev *sd, if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) return ov9640_s_fmt(sd, mf); - *v4l2_subdev_state_get_format(sd_state, 0) = *mf; - return 0; } |