summaryrefslogtreecommitdiff
path: root/drivers/memory/pl353-smc.c
diff options
context:
space:
mode:
authorZhen Lei <thunder.leizhen@huawei.com>2021-05-15 12:00:04 +0800
committerKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>2021-05-17 07:21:32 -0400
commit76e5624f3f9343a621dd3f4006f4e4d9c3f91e33 (patch)
tree9e8be595899a4bf589337af19672c63e437bb03a /drivers/memory/pl353-smc.c
parent907c5bbb514a4676160e79764522fff56ce3448e (diff)
memory: pl353: Fix error return code in pl353_smc_probe()
When no child nodes are matched, an appropriate error code -ENODEV should be returned. However, we currently do not explicitly assign this error code to 'err'. As a result, 0 was incorrectly returned. Fixes: fee10bd22678 ("memory: pl353: Add driver for arm pl353 static memory controller") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Link: https://lore.kernel.org/r/20210515040004.6983-1-thunder.leizhen@huawei.com Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Diffstat (limited to 'drivers/memory/pl353-smc.c')
-rw-r--r--drivers/memory/pl353-smc.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/memory/pl353-smc.c b/drivers/memory/pl353-smc.c
index 9c0a28416777..b0b251bb207f 100644
--- a/drivers/memory/pl353-smc.c
+++ b/drivers/memory/pl353-smc.c
@@ -407,6 +407,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
break;
}
if (!match) {
+ err = -ENODEV;
dev_err(&adev->dev, "no matching children\n");
goto out_clk_disable;
}