diff options
| author | Herve Codina <herve.codina@bootlin.com> | 2024-10-29 09:43:36 +0100 |
|---|---|---|
| committer | Philipp Zabel <p.zabel@pengutronix.de> | 2024-11-04 14:34:25 +0100 |
| commit | cf3e10cc0e88bba51d330ef851bcffa0bce1070c (patch) | |
| tree | b17a0e8e5cf3a1399815cec1036aea427b8eb94a /drivers/misc | |
| parent | 344ea0d36b8c9cb7668b002570159efe78a922c1 (diff) | |
misc: lan966x_pci: Fix dtc warn 'Missing interrupt-parent'
dtc generates the following warning when building the LAN966x devicetree
overlay (lan966x_pci.dtso):
Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
The oic interrupt parent is the PCI device itself. The PCI device node
is the node on which the dtbo will be applied and this node already has
properties needed.
In order to remove the warning, add the missing properties in the
overlay fragment node. Properties in this node will not be added when
the overlay is applied (which is what we expect) but makes dtc happy.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.au/
Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device")
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20241029084338.194942-3-herve.codina@bootlin.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/lan966x_pci.dtso | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/drivers/misc/lan966x_pci.dtso b/drivers/misc/lan966x_pci.dtso index e9b304c6ced3..7b196b0a0eb6 100644 --- a/drivers/misc/lan966x_pci.dtso +++ b/drivers/misc/lan966x_pci.dtso @@ -15,6 +15,16 @@ / { fragment@0 { target-path = ""; + + /* + * These properties allow to avoid a dtc warnings. + * The real interrupt controller is the PCI device itself. It + * is the node on which the device tree overlay will be applied. + * This node has those properties. + */ + #interrupt-cells = <1>; + interrupt-controller; + __overlay__ { #address-cells = <3>; #size-cells = <2>; |