diff options
| author | Daniel Golle <daniel@makrotopia.org> | 2023-04-03 02:17:19 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-04-03 10:13:00 +0100 |
| commit | b6f56cddb5f57a0b8da0ce582232a2f1933558c6 (patch) | |
| tree | b286bfe7c1d9b7da4bc5508195038c60d8582ad4 /drivers/net/dsa/mt7530.c | |
| parent | 56b029ddac8eebdeb3d8a15c8aed71a1c62e4924 (diff) | |
net: dsa: mt7530: make some noise if register read fails
Simply returning the negative error value instead of the read value
doesn't seem like a good idea. Return 0 instead and add WARN_ON_ONCE(1)
so this kind of error will not go unnoticed.
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/mt7530.c')
| -rw-r--r-- | drivers/net/dsa/mt7530.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index a0d99af897ac..18d4aa6bb996 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -224,9 +224,10 @@ mt7530_mii_read(struct mt7530_priv *priv, u32 reg) /* MT7530 uses 31 as the pseudo port */ ret = bus->write(bus, 0x1f, 0x1f, page); if (ret < 0) { + WARN_ON_ONCE(1); dev_err(&bus->dev, "failed to read mt7530 register\n"); - return ret; + return 0; } lo = bus->read(bus, 0x1f, r); |