diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-02-25 11:22:23 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-02-27 11:06:14 +0000 |
| commit | 06b9cce42634a50f2840777a66553b02320db5ef (patch) | |
| tree | 4ed5ab6bc3f7efe290468c12189575b85f3c2b0a /drivers/net/dsa/realtek | |
| parent | c26933639b5402c174c65c01d33f145622784012 (diff) | |
net: dsa: pass extack to .port_bridge_join driver methods
As FDB isolation cannot be enforced between VLAN-aware bridges in lack
of hardware assistance like extra FID bits, it seems plausible that many
DSA switches cannot do it. Therefore, they need to reject configurations
with multiple VLAN-aware bridges from the two code paths that can
transition towards that state:
- joining a VLAN-aware bridge
- toggling VLAN awareness on an existing bridge
The .port_vlan_filtering method already propagates the netlink extack to
the driver, let's propagate it from .port_bridge_join too, to make sure
that the driver can use the same function for both.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/realtek')
| -rw-r--r-- | drivers/net/dsa/realtek/rtl8366rb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/dsa/realtek/rtl8366rb.c b/drivers/net/dsa/realtek/rtl8366rb.c index fb6565e68401..1a3406b9e64c 100644 --- a/drivers/net/dsa/realtek/rtl8366rb.c +++ b/drivers/net/dsa/realtek/rtl8366rb.c @@ -1189,7 +1189,8 @@ rtl8366rb_port_disable(struct dsa_switch *ds, int port) static int rtl8366rb_port_bridge_join(struct dsa_switch *ds, int port, struct dsa_bridge bridge, - bool *tx_fwd_offload) + bool *tx_fwd_offload, + struct netlink_ext_ack *extack) { struct realtek_priv *priv = ds->priv; unsigned int port_bitmap = 0; |