diff options
| author | Sumera Priyadarsini <sylphrenadin@gmail.com> | 2020-08-23 19:22:45 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-08-24 18:04:09 -0700 |
| commit | 59ebb4305c432b6ca34fd9704c9294c1f16e5847 (patch) | |
| tree | e8d892d24cc2d6de7c2a19a5abcb17c6ea09c93e /drivers/net/dsa | |
| parent | 4341b7d9164093c14edc686deac6a9f36eb661b5 (diff) | |
net: ocelot: Add of_node_put() before return statement
Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.
Fix a potential memory leak in felix.c by inserting of_node_put()
before the return statement.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/ocelot/felix.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c index c69d9592a2b7..04bfa6e465ff 100644 --- a/drivers/net/dsa/ocelot/felix.c +++ b/drivers/net/dsa/ocelot/felix.c @@ -400,6 +400,7 @@ static int felix_parse_ports_node(struct felix *felix, if (err < 0) { dev_err(dev, "Unsupported PHY mode %s on port %d\n", phy_modes(phy_mode), port); + of_node_put(child); return err; } |