diff options
| author | Ioana Ciornei <ioana.ciornei@nxp.com> | 2019-11-21 21:15:25 +0200 |
|---|---|---|
| committer | Russell King (Oracle) <rmk+kernel@armlinux.org.uk> | 2021-07-02 16:36:33 +0100 |
| commit | fe6966540378a179f71f8fe0c55fab68019c5447 (patch) | |
| tree | a874f387b4a66db61847be1946d3e3411ccf993f /drivers/net/dummy.c | |
| parent | 2d8e5959299ba2fd165780baf6c4d7b302855c53 (diff) | |
dpaa2-eth: do not hold rtnl_lock on phylink_create() or _destroy()
The rtnl_lock should not be held when calling phylink_create() or
phylink_destroy() since it leads to the deadlock listed below:
[ 18.656576] rtnl_lock+0x18/0x20
[ 18.659798] sfp_bus_add_upstream+0x28/0x90
[ 18.663974] phylink_create+0x2cc/0x828
[ 18.667803] dpaa2_mac_connect+0x14c/0x2a8
[ 18.671890] dpaa2_eth_connect_mac+0x94/0xd8
Fix this by moving the _lock() and _unlock() calls just outside of
phylink_of_phy_connect() and phylink_disconnect_phy().
Fixes: 719479230893 ("dpaa2-eth: add MAC/PHY support through phylink")
Reported-by: Russell King <linux@armlinux.org.uk>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Diffstat (limited to 'drivers/net/dummy.c')
0 files changed, 0 insertions, 0 deletions