diff options
author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2022-01-08 15:26:06 +0100 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-01-09 16:52:18 -0800 |
commit | ba8a5863497251ca32786ad3db5e24b7375ddde2 (patch) | |
tree | 78b124bfb467d493cd0ab9547e7d0cec2ea0c358 /drivers/net/ethernet/alteon/acenic.h | |
parent | 21ef11eaf3f78dda7fd20abe6e60e27038cb06a3 (diff) |
net: alteon: Simplify DMA setting
As stated in [1], dma_set_mask() with a 64-bit mask will never fail if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.
If dma_set_mask_and_coherent() succeeds, 'ap->pci_using_dac' is known to be
1. So 'pci_using_dac' can be removed from the 'struct ace_private'.
Simplify code and remove some dead code accordingly.
[1]: https://lkml.org/lkml/2021/6/7/398
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/1a414c05c27b21c661aef61dffe1adcd1578b1f5.1641651917.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/alteon/acenic.h')
-rw-r--r-- | drivers/net/ethernet/alteon/acenic.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/alteon/acenic.h b/drivers/net/ethernet/alteon/acenic.h index 265fa601a258..ca5ce0cbbad1 100644 --- a/drivers/net/ethernet/alteon/acenic.h +++ b/drivers/net/ethernet/alteon/acenic.h @@ -692,7 +692,6 @@ struct ace_private __attribute__ ((aligned (SMP_CACHE_BYTES))); u32 last_tx, last_std_rx, last_mini_rx; #endif - int pci_using_dac; u8 firmware_major; u8 firmware_minor; u8 firmware_fix; |