summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/intel/igc/igc_ethtool.c
diff options
context:
space:
mode:
authorAndre Guedes <andre.guedes@intel.com>2020-03-18 16:00:53 -0700
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2020-04-19 11:46:47 -0700
commit58184b8ff0786b219772016a50ce07c6b3020846 (patch)
treeb53943b0771e52b90f98b2d78b40b0b385e80a29 /drivers/net/ethernet/intel/igc/igc_ethtool.c
parent23b7b511675669702ad32bf7f92dcf2ae05015ba (diff)
igc: Change igc_add_mac_filter() returning value
In case of success, igc_add_mac_filter() returns the index in adapter->mac_table where the requested filter was added. This information, however, is not used by any caller of that function. In fact, callers have extra code just to handle this returning index as 0 (success). So this patch changes the function to return 0 on success instead, and cleans up the extra code. Signed-off-by: Andre Guedes <andre.guedes@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc_ethtool.c')
-rw-r--r--drivers/net/ethernet/intel/igc/igc_ethtool.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index ff2a40496e4e..c9f4552c018b 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1269,7 +1269,6 @@ int igc_add_filter(struct igc_adapter *adapter, struct igc_nfc_filter *input)
err = igc_add_mac_steering_filter(adapter,
input->filter.dst_addr,
input->action, 0);
- err = min_t(int, err, 0);
if (err)
return err;
}
@@ -1279,7 +1278,6 @@ int igc_add_filter(struct igc_adapter *adapter, struct igc_nfc_filter *input)
input->filter.src_addr,
input->action,
IGC_MAC_STATE_SRC_ADDR);
- err = min_t(int, err, 0);
if (err)
return err;
}