diff options
| author | Lukas Wunner <lukas@wunner.de> | 2022-04-27 08:30:51 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-04-28 18:37:48 -0700 |
| commit | 07caad0bb1f8963e6e99b665bc17842d93762469 (patch) | |
| tree | 5d4e0f4508a27947e2cd257a117073d1f205cb75 /drivers/net/ethernet | |
| parent | 6fd1d51cfa253b5ee7dae18d7cf1df830e9b6137 (diff) | |
net: phy: Deduplicate interrupt disablement on PHY attach
phy_attach_direct() first calls phy_init_hw() (which restores interrupt
settings through ->config_intr()), then calls phy_disable_interrupts().
So if phydev->interrupts was previously set to 1, interrupts are briefly
enabled, then disabled, which seems nonsensical.
If it was previously set to 0, interrupts are disabled twice, which is
equally nonsensical.
Deduplicate interrupt disablement.
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/805ccdc606bd8898d59931bd4c7c68537ed6e550.1651040826.git.lukas@wunner.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet')
0 files changed, 0 insertions, 0 deletions