diff options
| author | Gao Feng <fgao@ikuai8.com> | 2016-11-25 10:05:06 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-11-27 20:04:28 -0500 |
| commit | e824265d632629c3d2583d86b8a816e886a5136c (patch) | |
| tree | 2129f2d0372f999506e34ebba2cb1050f78db011 /drivers/net/macvtap.c | |
| parent | a1cad5ee80ddaa833dd0d31c0612306532fbe53a (diff) | |
driver: macvtap: Unregister netdev rx_handler if macvtap_newlink fails
The macvtap_newlink registers the netdev rx_handler firstly, but it
does not unregister the handler if macvlan_common_newlink failed.
Signed-off-by: Gao Feng <fgao@ikuai8.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/macvtap.c')
| -rw-r--r-- | drivers/net/macvtap.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 070e3290aa6e..bceca2875771 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -491,7 +491,13 @@ static int macvtap_newlink(struct net *src_net, /* Don't put anything that may fail after macvlan_common_newlink * because we can't undo what it does. */ - return macvlan_common_newlink(src_net, dev, tb, data); + err = macvlan_common_newlink(src_net, dev, tb, data); + if (err) { + netdev_rx_handler_unregister(dev); + return err; + } + + return 0; } static void macvtap_dellink(struct net_device *dev, |