diff options
| author | Russell King <rmk+kernel@armlinux.org.uk> | 2017-01-04 21:00:51 +0000 |
|---|---|---|
| committer | Russell King <rmk+kernel@armlinux.org.uk> | 2017-01-05 22:33:11 +0000 |
| commit | 8263edcd6f63b01a37b8bbe08ce0198c426e61ec (patch) | |
| tree | 61da9e855ab56bb7df2e3de10e59c1510ff14f52 /drivers/net/phy/phy-core.c | |
| parent | 5fba97adb18287f36c450245f80c579f1efe6421 (diff) | |
net: phy: avoid setting unsupported EEE advertisments
We currently allow userspace to set any EEE advertisments it desires,
whether or not the PHY supports them. For example:
# ethtool --set-eee eth1 advertise 0xffffffff
# ethtool --show-eee eth1
EEE Settings for eth1:
EEE status: disabled
Tx LPI: disabled
Supported EEE link modes: 100baseT/Full
1000baseT/Full
10000baseT/Full
Advertised EEE link modes: 100baseT/Full
1000baseT/Full
1000baseKX/Full
10000baseT/Full
10000baseKX4/Full
10000baseKR/Full
Clearly, this is not sane, we should only allow link modes that are
supported to be advertised (as we do elsewhere.) Ensure that we mask
the MDIO_AN_EEE_ADV value with the capabilities retrieved from the
MDIO_PCS_EEE_ABLE register.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Diffstat (limited to 'drivers/net/phy/phy-core.c')
0 files changed, 0 insertions, 0 deletions