diff options
| author | Russell King <rmk+kernel@armlinux.org.uk> | 2020-03-13 10:48:32 +0000 |
|---|---|---|
| committer | Russell King (Oracle) <rmk+kernel@armlinux.org.uk> | 2021-09-19 13:22:16 +0100 |
| commit | b020661fc4a29c39f0051cd22493e26cc1541b17 (patch) | |
| tree | f57ae28d48de29813c6a87c3bb95b9d12bddb2f6 /drivers/net/phy/phy_device.c | |
| parent | 58339cd013b7e37739c54d06b2e9f226d99d2f50 (diff) | |
net: mtk_eth_soc: use resolved link config for PCS PHY
The SGMII PCS PHY needs to be updated with the link configuration in
the mac_link_up() call rather than in mac_config(). However,
mtk_sgmii_setup_mode_force() programs the SGMII block during
mac_config() when using 802.3z interface modes with the link
configuration.
Split that functionality from mtk_sgmii_setup_mode_force(), moving it
to a new mtk_sgmii_link_up() function, and call it from mac_link_up().
This does not look correct to me: 802.3z modes operate at a fixed
speed. The contents of mtk_sgmii_link_up() look more appropriate for
SGMII mode, but the original code definitely did not call
mtk_sgmii_setup_mode_force() for SGMII mode but only 802.3z mode.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Diffstat (limited to 'drivers/net/phy/phy_device.c')
0 files changed, 0 insertions, 0 deletions