diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2019-01-23 07:27:21 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-24 22:15:15 -0800 |
| commit | a016becd3a56cdb260013c8fe1d4aefc6edc4989 (patch) | |
| tree | 9e47392ab913ecf51d96fe9406994e3f2fc89c37 /drivers/net/phy/phylink.c | |
| parent | 8f4ebaaa8d97dc531a3f947a8d30a5a70fe38743 (diff) | |
net: phy: start state machine in phy_start only
The state machine is a no-op before phy_start() has been called.
Therefore let's enable it in phy_start() only. In phy_start()
let's call phy_start_machine() instead of phy_trigger_machine().
phy_start_machine is an alias for phy_trigger_machine but it makes
clearer that we start the state machine here instead of just
triggering a run.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phylink.c')
| -rw-r--r-- | drivers/net/phy/phylink.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 7d9910da5018..c1b6e05ba60c 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -676,7 +676,6 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy) __ETHTOOL_LINK_MODE_MASK_NBITS, pl->supported, __ETHTOOL_LINK_MODE_MASK_NBITS, phy->advertising); - phy_start_machine(phy); if (phy->irq > 0) phy_start_interrupts(phy); |