diff options
author | Russell King <rmk+kernel@armlinux.org.uk> | 2020-03-13 10:48:32 +0000 |
---|---|---|
committer | Russell King <rmk+kernel@armlinux.org.uk> | 2021-02-15 13:22:03 +0000 |
commit | 0213e77a4035bfc814251f975cd995aef237723d (patch) | |
tree | 3d0991a3a2beb388489e549228a695bef23843a6 /drivers/net/tun.c | |
parent | 28ef56cfa3ce93c75ce57a336d83896037df2784 (diff) |
net: mtk_eth_soc: use resolved link config for PCS PHY
The SGMII PCS PHY needs to be updated with the link configuration in
the mac_link_up() call rather than in mac_config(). However,
mtk_sgmii_setup_mode_force() programs the SGMII block during
mac_config() when using 802.3z interface modes with the link
configuration.
Split that functionality from mtk_sgmii_setup_mode_force(), moving it
to a new mtk_sgmii_link_up() function, and call it from mac_link_up().
This does not look correct to me: 802.3z modes operate at a fixed
speed. The contents of mtk_sgmii_link_up() look more appropriate for
SGMII mode, but the original code definitely did not call
mtk_sgmii_setup_mode_force() for SGMII mode but only 802.3z mode.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Diffstat (limited to 'drivers/net/tun.c')
0 files changed, 0 insertions, 0 deletions