summaryrefslogtreecommitdiff
path: root/drivers/net
diff options
context:
space:
mode:
authorFinn Thain <fthain@telegraphics.com.au>2020-02-16 08:03:32 +1100
committerDavid S. Miller <davem@davemloft.net>2020-02-16 19:48:22 -0800
commitd35bf9bc7d72a5e3055c808e5d5530a81a0c9a38 (patch)
tree01d3aa58104374b18b0c09d5f6ff2b0d603286bf /drivers/net
parent29660d50a9e3a88c2c930994ac59ba5e4e74f344 (diff)
net/sonic: Remove redundant netif_start_queue() call
The transmit queue must be running already otherwise sonic_send_packet() would not have been called. If the queue was stopped by the interrupt handler, the interrupt handler will restart it again. Tested-by: Stan Johnson <userm57@yahoo.com> Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/ethernet/natsemi/sonic.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c
index 9ecdd67e1410..1d6de6706875 100644
--- a/drivers/net/ethernet/natsemi/sonic.c
+++ b/drivers/net/ethernet/natsemi/sonic.c
@@ -327,7 +327,7 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev)
netif_dbg(lp, tx_queued, dev, "%s: stopping queue\n", __func__);
netif_stop_queue(dev);
/* after this packet, wait for ISR to free up some TDAs */
- } else netif_start_queue(dev);
+ }
netif_dbg(lp, tx_queued, dev, "%s: issuing Tx command\n", __func__);