summaryrefslogtreecommitdiff
path: root/drivers/net
diff options
context:
space:
mode:
authorLiang Chen <liangchen.linux@gmail.com>2023-08-24 20:31:31 +0800
committerJakub Kicinski <kuba@kernel.org>2023-08-25 18:52:11 -0700
commit215eb9f962091ebaab96be2c18cf5d0f5174a4d6 (patch)
treedc415f7b9179259e12e6e044d215fb826d7d81b5 /drivers/net
parentbebfbf07c7db7321e26b6aae0d7078d3d1294464 (diff)
veth: Avoid NAPI scheduling on failed SKB forwarding
When an skb fails to be forwarded to the peer(e.g., skb data buffer length exceeds MTU), it will not be added to the peer's receive queue. Therefore, we should schedule the peer's NAPI poll function only when skb forwarding is successful to avoid unnecessary overhead. Signed-off-by: Liang Chen <liangchen.linux@gmail.com> Link: https://lore.kernel.org/r/20230824123131.7673-1-liangchen.linux@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/veth.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index da44bb1331ff..d43e62ebc2fc 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -373,14 +373,13 @@ static netdev_tx_t veth_xmit(struct sk_buff *skb, struct net_device *dev)
if (likely(veth_forward_skb(rcv, skb, rq, use_napi) == NET_RX_SUCCESS)) {
if (!use_napi)
dev_lstats_add(dev, length);
+ else
+ __veth_xdp_flush(rq);
} else {
drop:
atomic64_inc(&priv->dropped);
}
- if (use_napi)
- __veth_xdp_flush(rq);
-
rcu_read_unlock();
return NETDEV_TX_OK;