summaryrefslogtreecommitdiff
path: root/drivers/pci/pcie/portdrv_core.c
diff options
context:
space:
mode:
authorBjorn Helgaas <bhelgaas@google.com>2014-04-29 12:51:55 -0600
committerBjorn Helgaas <bhelgaas@google.com>2014-04-29 17:36:44 -0600
commit1e358f94c00570f88a590cabe718daf835440cc9 (patch)
tree3ac5fcf7100d63dc4aad0e8ba6392353f56c5458 /drivers/pci/pcie/portdrv_core.c
parentefdd4070f38e962d69c11f23c5aa033121a8cf0f (diff)
PCI: Fix use of uninitialized MPS value
If "pcie_bus_config == PCIE_BUS_PERFORMANCE", we don't initialize "smpss", so we pass a pointer to garbage into pcie_bus_configure_set(), where we compute "mps" based on the garbage. We then pass the garbage "mps" to pcie_write_mps(), which ignores it in the PCIE_BUS_PERFORMANCE case. Coverity isn't smart enough to deduce that we ignore the garbage (it's a lot to expect from a human, too), so initialize "smpss" to a safe value in all cases. Found by Coverity (CID 146454). Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/pcie/portdrv_core.c')
0 files changed, 0 insertions, 0 deletions