summaryrefslogtreecommitdiff
path: root/drivers/phy/ti
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2022-09-22 14:21:07 +0300
committerVinod Koul <vkoul@kernel.org>2022-09-24 11:59:37 +0530
commita270cc137ba942af554c18db551b9487f04f43a4 (patch)
treefb0849e9da15bd7377b3bf932f39406252c3ff17 /drivers/phy/ti
parent60d9b6aaabe827e5ed025355e7d4622f6506b91e (diff)
phy: ti: phy-j721e-wiz: fix reference leaks in wiz_probe()
These two error paths need to call of_node_put(child_node) before returning. Fixes: edd473d4293a ("phy: ti: phy-j721e-wiz: add support for j7200-wiz-10g") Fixes: 7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Roger Quadros <rogerq@kernel.org> Link: https://lore.kernel.org/r/YyxFI8aW23IC/21U@kili Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/ti')
-rw-r--r--drivers/phy/ti/phy-j721e-wiz.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index 1f4f585a84ad..41725c6bcdf6 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -1413,7 +1413,8 @@ static int wiz_probe(struct platform_device *pdev)
if (IS_ERR(wiz->scm_regmap)) {
if (wiz->type == J7200_WIZ_10G) {
dev_err(dev, "Couldn't get ti,scm regmap\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto err_addr_to_resource;
}
wiz->scm_regmap = NULL;
@@ -1463,7 +1464,7 @@ static int wiz_probe(struct platform_device *pdev)
ret = wiz_get_lane_phy_types(dev, wiz);
if (ret)
- return ret;
+ goto err_addr_to_resource;
wiz->dev = dev;
wiz->regmap = regmap;