diff options
| author | Colin Ian King <colin.king@canonical.com> | 2021-01-11 14:46:48 +0000 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-01-13 10:25:10 +0100 |
| commit | d26cbdd27f8c4ff2f3df227a8bc5782697ecce51 (patch) | |
| tree | 8352fb176843fd6f5b3a6e23ab1aac7245c5ba10 /drivers/platform/surface/surface_acpi_notify.c | |
| parent | d69cd7eea93eb59a93061beeb43e4f5e19afc4ea (diff) | |
platform/surface: fix potential integer overflow on shift of a int
The left shift of int 32 bit integer constant 1 is evaluated using 32 bit
arithmetic and then passed as a 64 bit function argument. In the case where
func is 32 or more this can lead to an oveflow. Avoid this by shifting
using the BIT_ULL macro instead.
Addresses-Coverity: ("Unintentional integer overflow")
Fixes: fc00bc8ac1da ("platform/surface: Add Surface ACPI Notify driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210111144648.20498-1-colin.king@canonical.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/surface/surface_acpi_notify.c')
| -rw-r--r-- | drivers/platform/surface/surface_acpi_notify.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/surface/surface_acpi_notify.c b/drivers/platform/surface/surface_acpi_notify.c index 8cd67a669c86..ef9c1f8e8336 100644 --- a/drivers/platform/surface/surface_acpi_notify.c +++ b/drivers/platform/surface/surface_acpi_notify.c @@ -188,7 +188,7 @@ static int san_acpi_notify_event(struct device *dev, u64 func, union acpi_object *obj; int status = 0; - if (!acpi_check_dsm(san, &SAN_DSM_UUID, SAN_DSM_REVISION, 1 << func)) + if (!acpi_check_dsm(san, &SAN_DSM_UUID, SAN_DSM_REVISION, BIT_ULL(func))) return 0; dev_dbg(dev, "notify event %#04llx\n", func); |