diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-06-21 15:04:57 +0200 |
|---|---|---|
| committer | Thierry Reding <thierry.reding@gmail.com> | 2021-06-30 19:12:20 +0200 |
| commit | fb2cb3bff9e0ede1709620809374dd14c07b1e16 (patch) | |
| tree | b869ea14f71146ff847b53ba89e1a31e05fdeca0 /drivers/pwm/pwm-vt8500.c | |
| parent | 2f1a3bd4510afd8cf5ab5a6169ad64981a62dccf (diff) | |
pwm: vt8500: Drop if with an always false condition
vt8500_pwm_remove() is only called after vt8500_pwm_probe() returned
successfully. In this case driver data was set to a non-NULL value
and so chip can never be NULL.
While touching this code also put declaration and assignment in a single
line.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm/pwm-vt8500.c')
| -rw-r--r-- | drivers/pwm/pwm-vt8500.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/pwm/pwm-vt8500.c b/drivers/pwm/pwm-vt8500.c index f9eb36be9088..7164df2fbacf 100644 --- a/drivers/pwm/pwm-vt8500.c +++ b/drivers/pwm/pwm-vt8500.c @@ -238,11 +238,8 @@ static int vt8500_pwm_probe(struct platform_device *pdev) static int vt8500_pwm_remove(struct platform_device *pdev) { - struct vt8500_chip *chip; + struct vt8500_chip *chip = platform_get_drvdata(pdev); - chip = platform_get_drvdata(pdev); - if (chip == NULL) - return -ENODEV; clk_unprepare(chip->clk); |