summaryrefslogtreecommitdiff
path: root/drivers/ras
diff options
context:
space:
mode:
authorTony Luck <tony.luck@intel.com>2019-05-06 13:13:22 +0200
committerBorislav Petkov <bp@suse.de>2019-06-08 17:39:24 +0200
commit60fd42d26cc7ec8847598da50ebf27e3c9647d7b (patch)
treed945852ed161d0b9349a8e2037cda5c8e31a6c55 /drivers/ras
parentf57518cd56e2919afbcef3839122a75e291c7f85 (diff)
RAS/CEC: Add CONFIG_RAS_CEC_DEBUG and move CEC debug features there
The pfn and array files in (debugfs)/ras/cec are intended for debugging the CEC code itself. They are not needed on production systems, so the default setting for this CONFIG option is "n". [ bp: Have it with less ifdeffery by using IS_ENABLED(). ] Signed-off-by: Tony Luck <tony.luck@intel.com> Signed-off-by: Borislav Petkov <bp@suse.de>
Diffstat (limited to 'drivers/ras')
-rw-r--r--drivers/ras/cec.c26
1 files changed, 14 insertions, 12 deletions
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index dc08c705b493..0907dc6f4afe 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -486,18 +486,6 @@ static int __init create_debugfs_nodes(void)
return -1;
}
- pfn = debugfs_create_file("pfn", S_IRUSR | S_IWUSR, d, &dfs_pfn, &pfn_ops);
- if (!pfn) {
- pr_warn("Error creating pfn debugfs node!\n");
- goto err;
- }
-
- array = debugfs_create_file("array", S_IRUSR, d, NULL, &array_ops);
- if (!array) {
- pr_warn("Error creating array debugfs node!\n");
- goto err;
- }
-
decay = debugfs_create_file("decay_interval", S_IRUSR | S_IWUSR, d,
&decay_interval, &decay_interval_ops);
if (!decay) {
@@ -512,6 +500,20 @@ static int __init create_debugfs_nodes(void)
goto err;
}
+ if (!IS_ENABLED(CONFIG_RAS_CEC_DEBUG))
+ return 0;
+
+ pfn = debugfs_create_file("pfn", S_IRUSR | S_IWUSR, d, &dfs_pfn, &pfn_ops);
+ if (!pfn) {
+ pr_warn("Error creating pfn debugfs node!\n");
+ goto err;
+ }
+
+ array = debugfs_create_file("array", S_IRUSR, d, NULL, &array_ops);
+ if (!array) {
+ pr_warn("Error creating array debugfs node!\n");
+ goto err;
+ }
return 0;