summaryrefslogtreecommitdiff
path: root/drivers/rtc/rtc-pcf8583.c
diff options
context:
space:
mode:
authorSachin Kamat <sachin.kamat@linaro.org>2013-07-03 15:06:02 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2013-07-03 16:07:48 -0700
commitd1bda80afd36c5eeb79a8f5a53c9b3e23350d3a9 (patch)
treea730017a51c58678c45cdad5dd907e3d44f4f7c2 /drivers/rtc/rtc-pcf8583.c
parent369015fbd40655f86384a3e7d5452f9c61eb26e9 (diff)
drivers/rtc/rtc-pcf8583.c: move assignment outside if condition
Fixes the following checkpatch error: ERROR: do not use assignment in if condition Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc/rtc-pcf8583.c')
-rw-r--r--drivers/rtc/rtc-pcf8583.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-pcf8583.c b/drivers/rtc/rtc-pcf8583.c
index 95886dcf4a39..9971f7f7cac8 100644
--- a/drivers/rtc/rtc-pcf8583.c
+++ b/drivers/rtc/rtc-pcf8583.c
@@ -188,7 +188,8 @@ static int pcf8583_rtc_read_time(struct device *dev, struct rtc_time *tm)
dev_warn(dev, "resetting control %02x -> %02x\n",
ctrl, new_ctrl);
- if ((err = pcf8583_set_ctrl(client, &new_ctrl)) < 0)
+ err = pcf8583_set_ctrl(client, &new_ctrl);
+ if (err < 0)
return err;
}