summaryrefslogtreecommitdiff
path: root/drivers/rtc/rtc-rv3032.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2021-10-12 13:10:28 +0300
committerAlexandre Belloni <alexandre.belloni@bootlin.com>2021-10-15 21:07:23 +0200
commitc3336b8ac6091df60a5c1049a8c685d0b947cc61 (patch)
tree707056c38198921586661370bbd8ffc7193ced01 /drivers/rtc/rtc-rv3032.c
parent24d23181e43d72ca692a479e70dfe5b0b5dd33f1 (diff)
rtc: rv3032: fix error handling in rv3032_clkout_set_rate()
Do not call rv3032_exit_eerd() if the enter function fails but don't forget to call the exit when the enter succeeds. Fixes: 2eeaa532acca ("rtc: rv3032: Add a driver for Microcrystal RV-3032") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20211012101028.GT2083@kadam
Diffstat (limited to 'drivers/rtc/rtc-rv3032.c')
-rw-r--r--drivers/rtc/rtc-rv3032.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/rtc/rtc-rv3032.c b/drivers/rtc/rtc-rv3032.c
index d63102d5cb1e..1b62ed2f1459 100644
--- a/drivers/rtc/rtc-rv3032.c
+++ b/drivers/rtc/rtc-rv3032.c
@@ -617,11 +617,11 @@ static int rv3032_clkout_set_rate(struct clk_hw *hw, unsigned long rate,
ret = rv3032_enter_eerd(rv3032, &eerd);
if (ret)
- goto exit_eerd;
+ return ret;
ret = regmap_write(rv3032->regmap, RV3032_CLKOUT1, hfd & 0xff);
if (ret)
- return ret;
+ goto exit_eerd;
ret = regmap_write(rv3032->regmap, RV3032_CLKOUT2, RV3032_CLKOUT2_OS |
FIELD_PREP(RV3032_CLKOUT2_HFD_MSK, hfd >> 8));