diff options
| author | Yicong Yang <yangyicong@hisilicon.com> | 2021-04-12 19:58:27 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-04-12 17:07:37 +0100 |
| commit | 4c84e42d29afa3dce201a4db747db2a5ba404604 (patch) | |
| tree | 14e01ee9644bf811a0e4a5687bb3faef1ecab01c /drivers/spi/spi-hisi-sfc-v3xx.c | |
| parent | 828b480977421e9fbe93ecbdc65689ec7cc1e834 (diff) | |
spi: hisi-sfc-v3xx: fix potential irq race condition
We mask the irq when the command completion is timeout. This won't
stop the already running irq handler. Use sychronize_irq() after
we mask the irq, to make sure there is no running handler.
Acked-by: John Garry <john.garry@huawei.com>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Link: https://lore.kernel.org/r/1618228708-37949-2-git-send-email-yangyicong@hisilicon.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-hisi-sfc-v3xx.c')
| -rw-r--r-- | drivers/spi/spi-hisi-sfc-v3xx.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-hisi-sfc-v3xx.c b/drivers/spi/spi-hisi-sfc-v3xx.c index 385eb7bba05a..0d9e10302b66 100644 --- a/drivers/spi/spi-hisi-sfc-v3xx.c +++ b/drivers/spi/spi-hisi-sfc-v3xx.c @@ -342,6 +342,7 @@ static int hisi_sfc_v3xx_generic_exec_op(struct hisi_sfc_v3xx_host *host, ret = 0; hisi_sfc_v3xx_disable_int(host); + synchronize_irq(host->irq); host->completion = NULL; } else { ret = hisi_sfc_v3xx_wait_cmd_idle(host); |