diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-05-05 22:29:23 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-05-10 11:19:41 +0200 |
| commit | a3417158b9321bbaf21d967f85cdd049ff2f5685 (patch) | |
| tree | d178b4b55ebda7e6d3ec94cef7de235a1dc96ab8 /drivers/staging/fieldbus | |
| parent | 32dcd0724237a435983f9cf60005513c9ae48e44 (diff) | |
staging: fieldbus: anybus: Refuse registering drivers without .probe()
A driver without .probe() callback could never bind to a device because
anybus_bus_probe() returned an error for such a driver. So refuse to
register such a useless driver.
Reviewed-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210505202923.198607-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/fieldbus')
| -rw-r--r-- | drivers/staging/fieldbus/anybuss/host.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/staging/fieldbus/anybuss/host.c b/drivers/staging/fieldbus/anybuss/host.c index de6c287efa03..0f730efe9a6d 100644 --- a/drivers/staging/fieldbus/anybuss/host.c +++ b/drivers/staging/fieldbus/anybuss/host.c @@ -1183,8 +1183,6 @@ static int anybus_bus_probe(struct device *dev) struct anybuss_client *adev = to_anybuss_client(dev); - if (!adrv->probe) - return -ENODEV; return adrv->probe(adev); } @@ -1208,6 +1206,9 @@ static struct bus_type anybus_bus = { int anybuss_client_driver_register(struct anybuss_client_driver *drv) { + if (!drv->probe) + return -ENODEV; + drv->driver.bus = &anybus_bus; return driver_register(&drv->driver); } |