summaryrefslogtreecommitdiff
path: root/drivers/staging/greybus/es2.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@hovoldconsulting.com>2016-07-13 09:34:00 -0500
committerAlex Elder <elder@linaro.org>2016-07-13 09:44:05 -0500
commit34873949885ad66f9bc6ad6baff78aed4846c092 (patch)
tree24c4aece60448d689c61be5a72ced907270a61a4 /drivers/staging/greybus/es2.c
parentc14118a8411c4d7ad1dd6dd501beb33ae1268b08 (diff)
greybus: es2: fix arpc return value
ARPC should return 0 on success, but instead was returning the number of jiffies left until the timeout. This caused cport_reset() to report an error and an incorrect error message to be printed when disabling a connection. Reported-by: Alex Elder <elder@linaro.org> Signed-off-by: Johan Hovold <johan@hovoldconsulting.com> Tested-by: Alex Elder <elder@linaro.org> Signed-off-by: Alex Elder <elder@linaro.org>
Diffstat (limited to 'drivers/staging/greybus/es2.c')
-rw-r--r--drivers/staging/greybus/es2.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index b763b27ce9ef..6ada1ee128fc 100644
--- a/drivers/staging/greybus/es2.c
+++ b/drivers/staging/greybus/es2.c
@@ -1204,6 +1204,8 @@ static int arpc_sync(struct es2_ap_dev *es2, u8 type, void *payload,
*result = rpc->resp->result;
if (*result)
retval = -EREMOTEIO;
+ else
+ retval = 0;
out_arpc_del:
spin_lock_irqsave(&es2->arpc_lock, flags);