summaryrefslogtreecommitdiff
path: root/drivers/staging/greybus
diff options
context:
space:
mode:
authorUwe Kleine-König <uwe@kleine-koenig.org>2020-12-08 11:16:07 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-12-09 15:49:04 +0100
commitc11cbd57f02d612181c5abd1306670b7f6c447c9 (patch)
tree0cc6186877b1ab96040140e1662e7cb1b2cd392d /drivers/staging/greybus
parent518b466a21ad7fa1e338fa4ed9d180ef439d3bc0 (diff)
staging: greybus: Add TODO item about modernizing the pwm code
drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers should stick to the atomic API instead. Acked-by: Johan Hovold <johan@kernel.org> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> Link: https://lore.kernel.org/r/20201208101607.42785-1-uwe@kleine-koenig.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/greybus')
-rw-r--r--drivers/staging/greybus/TODO2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO
index 31f1f2cb401c..6461e0132fe3 100644
--- a/drivers/staging/greybus/TODO
+++ b/drivers/staging/greybus/TODO
@@ -1,3 +1,5 @@
* Convert all uses of the old GPIO API from <linux/gpio.h> to the
GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
lines from device tree or ACPI.
+* Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity,
+ ::enable and ::disable.