diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-03-14 10:55:01 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-16 11:20:55 +0900 |
| commit | 5d1ae279c235e5f353d0f11e6b4bed3079732327 (patch) | |
| tree | 72906c524019853d9f91078bd5aadcf7dd3dcb57 /drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | |
| parent | 2bbe97830ae623a519291eece719ee74108571ff (diff) | |
staging: atomisp: silence an array overflow warning
Static checkers complain that we should check if "i" is in bounds
before we check if "var8[i]" is a NUL char. This bug is harmless but
also easy to fix.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c')
| -rw-r--r-- | drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c index 292949273d00..add00932f6c9 100644 --- a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c +++ b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c @@ -669,7 +669,7 @@ int gmin_get_config_var(struct device *dev, const char *var, char *out, size_t * /* Our variable names are ASCII by construction, but EFI names * are wide chars. Convert and zero-pad. */ memset(var16, 0, sizeof(var16)); - for (i=0; var8[i] && i < sizeof(var8); i++) + for (i = 0; i < sizeof(var8) && var8[i]; i++) var16[i] = var8[i]; /* To avoid owerflows when calling the efivar API */ |