diff options
| author | Nikita Yushchenko <nikita.yoush@cogentembedded.com> | 2021-09-27 19:06:49 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-28 09:11:26 +0200 |
| commit | bd46a1f12c0bdae950a7968a22815291e3c435fe (patch) | |
| tree | 2c6dfe438e25cb5286bc84a2b88c9cbb63455ce1 /drivers/staging/most | |
| parent | 9b27a62d11be1afbccbefddaad39761c8212fd92 (diff) | |
staging: most: dim2: use if statements instead of ?: expressions
For better maintainability, replace conditional expressions with if
statements in the drivers' probe routine.
Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Link: https://lore.kernel.org/r/20210927160649.29209-1-nikita.yoush@cogentembedded.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/most')
| -rw-r--r-- | drivers/staging/most/dim2/dim2.c | 23 |
1 files changed, 12 insertions, 11 deletions
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index 9300040ec84c..e8b03fa90e80 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -732,7 +732,8 @@ static int dim2_probe(struct platform_device *pdev) struct dim2_hdm *dev; struct resource *res; int ret, i; - u8 dev_fcnt, hal_ret; + u8 hal_ret; + u8 dev_fcnt = fcnt; int irq; enum { MLB_INT_IDX, AHB0_INT_IDX }; @@ -765,16 +766,16 @@ static int dim2_probe(struct platform_device *pdev) of_id = of_match_node(dim2_of_match, pdev->dev.of_node); pdata = of_id->data; - ret = pdata && pdata->enable ? pdata->enable(pdev) : 0; - if (ret) - return ret; - - dev->disable_platform = pdata ? pdata->disable : NULL; - - if (pdata && pdata->fcnt) - dev_fcnt = pdata->fcnt; - else - dev_fcnt = fcnt; + if (pdata) { + if (pdata->enable) { + ret = pdata->enable(pdev); + if (ret) + return ret; + } + dev->disable_platform = pdata->disable; + if (pdata->fcnt) + dev_fcnt = pdata->fcnt; + } dev_info(&pdev->dev, "sync: num of frames per sub-buffer: %u\n", dev_fcnt); |