diff options
| author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2014-02-12 11:54:32 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-02-14 09:19:53 -0800 |
| commit | bacb6de62cce0af3be40248c89f980b604b8a54f (patch) | |
| tree | d46420b0b1466202c3bce121fb465061496ec914 /drivers/staging/rtl8188eu/TODO | |
| parent | cf867c3930b9b685364ec4fda20ff8a5a1e06ad6 (diff) | |
staging: Additional item for rtl8188eu TODO list
The rtw_recv_indicatepkt() function in the file named
drivers/staging/rtl8188eu/os_dep/recv_linux.c has this strange code:
rcu_read_lock();
rcu_dereference(padapter->pnetdev->rx_handler_data);
rcu_read_unlock();
This code has no effect. Normally, you would assign the result of
rcu_dereference() to some variable, but it is not clear from the
code what variable that would be. Therefore, this patch applies to
the TODO file instead of the code itself.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rtl8188eu/TODO')
| -rw-r--r-- | drivers/staging/rtl8188eu/TODO | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/staging/rtl8188eu/TODO b/drivers/staging/rtl8188eu/TODO index f7f389c40e71..b574b235b340 100644 --- a/drivers/staging/rtl8188eu/TODO +++ b/drivers/staging/rtl8188eu/TODO @@ -9,6 +9,11 @@ TODO: - merge Realtek's bugfixes and new features into the driver - switch to use LIB80211 - switch to use MAC80211 +- figure out what to do with this code in rtw_recv_indicatepkt(): + rcu_read_lock(); + rcu_dereference(padapter->pnetdev->rx_handler_data); + rcu_read_unlock(); + Perhaps delete it, perhaps assign to some local variable. Please send any patches to Greg Kroah-Hartman <gregkh@linux.com>, and Larry Finger <Larry.Finger@lwfinger.net>. |