diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2014-04-01 13:30:05 +1030 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2014-04-01 14:20:26 +1030 |
| commit | 22c9bcad859d5c969289b3b37084a96c621f8f2c (patch) | |
| tree | cc67e59e1ff7e575c6581b28f828a761e374aad3 /drivers/staging/speakup/speakup.h | |
| parent | 57673c2b0baa900dddae3b9eb3d7748ebf550eb3 (diff) | |
staging: fix up speakup kobject mode
It uses the unnecessary S_IFREG bit which broke when my
stricter-checking-for-mode patch went in.
Since we're fixing it anyway, the extra level of indirection is
confusing for readers (ROOT_W == rw-r--r-- for example).
Also, many of these are other-writable. Is that really intended?
I'll-queue-this-patch-up-in-a-bit-by: Greg KH <greg@kroah.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/staging/speakup/speakup.h')
| -rw-r--r-- | drivers/staging/speakup/speakup.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/speakup/speakup.h b/drivers/staging/speakup/speakup.h index 0126f714821a..a7bcceec436a 100644 --- a/drivers/staging/speakup/speakup.h +++ b/drivers/staging/speakup/speakup.h @@ -12,8 +12,6 @@ /* proc permissions */ #define USER_R (S_IFREG|S_IRUGO) #define USER_W (S_IFREG|S_IWUGO) -#define USER_RW (S_IFREG|S_IRUGO|S_IWUGO) -#define ROOT_W (S_IFREG|S_IRUGO|S_IWUSR) #define TOGGLE_0 .u.n = {NULL, 0, 0, 1, 0, 0, NULL } #define TOGGLE_1 .u.n = {NULL, 1, 0, 1, 0, 0, NULL } |