diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-05-20 00:27:18 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-05-25 18:56:32 +0200 |
| commit | e45423d76f1c229b1a30ddde205a72774cdb12c6 (patch) | |
| tree | f817f3dbf4fe06ad49da3960b7465c961df43bfc /drivers/staging/speakup | |
| parent | d70dd245215d6456584119534e6870a9c7b9b9c2 (diff) | |
staging: speakup: signedness bug in spk_ttyio_in_nowait()
On most of the common arches char is signed so it can't ever == 0xff.
Let's fix this by making it a u8.
Fixes: 6b9ad1c742bf ("staging: speakup: add send_xchar, tiocmset and input functionality for tty")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/speakup')
| -rw-r--r-- | drivers/staging/speakup/spk_ttyio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c index 6e0f042f6a44..8ed7c71c712f 100644 --- a/drivers/staging/speakup/spk_ttyio.c +++ b/drivers/staging/speakup/spk_ttyio.c @@ -220,7 +220,7 @@ static unsigned char spk_ttyio_in(void) static unsigned char spk_ttyio_in_nowait(void) { - char rv = ttyio_in(0); + u8 rv = ttyio_in(0); return (rv == 0xff) ? 0 : rv; } |