summaryrefslogtreecommitdiff
path: root/drivers/usb/host/xhci-tegra.c
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2021-06-16 12:45:17 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-06-17 15:26:40 +0200
commit9ea90e9fadb6cffb383ee23b132c36a88ee69019 (patch)
treeb9caa6a357f046ec7f59e4b64055680686a8b51d /drivers/usb/host/xhci-tegra.c
parentd143825baf15f204dac60acdf95e428182aa3374 (diff)
usb: host: xhci-tegra: add missing put_device() in tegra_xusb_probe()
Goto put_padctl to put refcount of device on error in tegra_xusb_probe() Fixes: 971ee247060d ("usb: xhci: tegra: Enable ELPG for runtime/system PM") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20210616044519.2183826-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/host/xhci-tegra.c')
-rw-r--r--drivers/usb/host/xhci-tegra.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index ce97ff054c68..f30030a3e51b 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -1454,12 +1454,16 @@ static int tegra_xusb_probe(struct platform_device *pdev)
return PTR_ERR(tegra->padctl);
np = of_parse_phandle(pdev->dev.of_node, "nvidia,xusb-padctl", 0);
- if (!np)
- return -ENODEV;
+ if (!np) {
+ err = -ENODEV;
+ goto put_padctl;
+ }
tegra->padctl_irq = of_irq_get(np, 0);
- if (tegra->padctl_irq <= 0)
- return (tegra->padctl_irq == 0) ? -ENODEV : tegra->padctl_irq;
+ if (tegra->padctl_irq <= 0) {
+ err = (tegra->padctl_irq == 0) ? -ENODEV : tegra->padctl_irq;
+ goto put_padctl;
+ }
tegra->host_clk = devm_clk_get(&pdev->dev, "xusb_host");
if (IS_ERR(tegra->host_clk)) {