diff options
author | Gautam Dawar <gautam.dawar@amd.com> | 2023-03-01 22:02:01 +0530 |
---|---|---|
committer | Michael S. Tsirkin <mst@redhat.com> | 2023-03-13 02:29:11 -0400 |
commit | 5a522150093a0eabae9470a70a37a6e436bfad08 (patch) | |
tree | b1e47e6802a67888a1ddf6d71a835b6fd8fde3f2 /drivers/vdpa | |
parent | 09e65ee9059d76b89cb713795748805efd3f50c6 (diff) |
vhost-vdpa: free iommu domain after last use during cleanup
Currently vhost_vdpa_cleanup() unmaps the DMA mappings by calling
`iommu_unmap(v->domain, map->start, map->size);`
from vhost_vdpa_general_unmap() when the parent vDPA driver doesn't
provide DMA config operations.
However, the IOMMU domain referred to by `v->domain` is freed in
vhost_vdpa_free_domain() before vhost_vdpa_cleanup() in
vhost_vdpa_release() which results in NULL pointer de-reference.
Accordingly, moving the call to vhost_vdpa_free_domain() in
vhost_vdpa_cleanup() would makes sense. This will also help
detaching the dma device in error handling of vhost_vdpa_alloc_domain().
This issue was observed on terminating QEMU with SIGQUIT.
Fixes: 037d4305569a ("vhost-vdpa: call vhost_vdpa_cleanup during the release")
Signed-off-by: Gautam Dawar <gautam.dawar@amd.com>
Message-Id: <20230301163203.29883-1-gautam.dawar@amd.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Diffstat (limited to 'drivers/vdpa')
0 files changed, 0 insertions, 0 deletions