summaryrefslogtreecommitdiff
path: root/drivers/xen
diff options
context:
space:
mode:
authorQais Yousef <qais.yousef@arm.com>2020-03-23 13:51:06 +0000
committerThomas Gleixner <tglx@linutronix.de>2020-03-25 12:59:36 +0100
commita926f81d2f6c51458e116c5b3ff3af471b56098f (patch)
treec6ec0aad3c3e91cac0efbb208cc2ccd3872627b7 /drivers/xen
parent02addaeaa7e5fa238963972d7030fa7ad57d9f1a (diff)
xen/cpuhotplug: Replace cpu_up/down() with device_online/offline()
The core device API performs extra housekeeping bits that are missing from directly calling cpu_up/down(). See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and serialization during LPM") for an example description of what might go wrong. This also prepares to make cpu_up/down() a private interface of the cpu subsystem. Signed-off-by: Qais Yousef <qais.yousef@arm.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Juergen Gross <jgross@suse.com> Link: https://lkml.kernel.org/r/20200323135110.30522-14-qais.yousef@arm.com
Diffstat (limited to 'drivers/xen')
-rw-r--r--drivers/xen/cpu_hotplug.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
index f192b6f42da9..ec975decb5de 100644
--- a/drivers/xen/cpu_hotplug.c
+++ b/drivers/xen/cpu_hotplug.c
@@ -94,7 +94,7 @@ static int setup_cpu_watcher(struct notifier_block *notifier,
for_each_possible_cpu(cpu) {
if (vcpu_online(cpu) == 0) {
- (void)cpu_down(cpu);
+ device_offline(get_cpu_device(cpu));
set_cpu_present(cpu, false);
}
}