diff options
| author | Sui Jingfeng <suijingfeng@loongson.cn> | 2023-08-09 06:34:06 +0800 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2023-08-23 17:19:14 -0500 |
| commit | b421364a905e05d62f889786d25954c5a4128c80 (patch) | |
| tree | b62f6c889853e9cd0451905f8b045310aa232256 /drivers | |
| parent | 60b4925d1aeaf0c46e540949c50818b9be2c896a (diff) | |
PCI/VGA: Simplify vga_arbiter_notify_clients()
In vga_arbiter_notify_clients(), "new_state" was computed during every loop
iteration even though it doesn't depend on anything that changes during the
loop. Move the computation outside the loop.
[bhelgaas: drop renames that obscure the purpose, commit log]
Link: https://lore.kernel.org/r/20230808223412.1743176-6-sui.jingfeng@linux.dev
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/pci/vgaarb.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c index 443cf1a74c0b..685681b0e5af 100644 --- a/drivers/pci/vgaarb.c +++ b/drivers/pci/vgaarb.c @@ -1477,12 +1477,10 @@ static void vga_arbiter_notify_clients(void) if (!vga_arbiter_used) return; + new_state = (vga_count > 1) ? false : true; + spin_lock_irqsave(&vga_lock, flags); list_for_each_entry(vgadev, &vga_list, list) { - if (vga_count > 1) - new_state = false; - else - new_state = true; if (vgadev->set_decode) { new_decodes = vgadev->set_decode(vgadev->pdev, new_state); |