diff options
| author | Sumera Priyadarsini <sylphrenadin@gmail.com> | 2020-08-29 23:27:04 +0530 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2020-09-10 00:57:42 -0700 |
| commit | da9c43dc0e2ec5c42a3d414e389feb30467000e2 (patch) | |
| tree | 67aeb20e55fbb56a94a9f3037695dacb62e8235a /drivers | |
| parent | 73a203b0dc56d2e8d4facc3820b0fcab43a300e1 (diff) | |
clk: versatile: Add of_node_put() before return statement
Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.
Fix a potential memory leak in clk-impd1.c by inserting
of_node_put() before a return statement.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Link: https://lore.kernel.org/r/20200829175704.GA10998@Kaladin
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/clk/versatile/clk-impd1.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/clk/versatile/clk-impd1.c b/drivers/clk/versatile/clk-impd1.c index ca798249544d..85c395df9c00 100644 --- a/drivers/clk/versatile/clk-impd1.c +++ b/drivers/clk/versatile/clk-impd1.c @@ -109,8 +109,10 @@ static int integrator_impd1_clk_probe(struct platform_device *pdev) for_each_available_child_of_node(np, child) { ret = integrator_impd1_clk_spawn(dev, np, child); - if (ret) + if (ret) { + of_node_put(child); break; + } } return ret; |