diff options
| author | Filipe Manana <fdmanana@suse.com> | 2023-03-21 11:13:57 +0000 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-04-17 18:01:20 +0200 |
| commit | ba4ec8fbce6c8b629a26d78cdd4a308cd0a503ca (patch) | |
| tree | ee975e9e785c5da5af9ec8b24c95d5c6afec12f8 /fs/btrfs/block-rsv.c | |
| parent | b13d57db90b859dadb33ccdb3716c9c3ed0a825d (diff) | |
btrfs: fix calculation of the global block reserve's size
At btrfs_update_global_block_rsv(), we are assuming an unlink operation
uses 5 metadata units, but that's not true anymore, it uses 6 since the
commit bca4ad7c0b54 ("btrfs: reserve correct number of items for unlink
and rmdir"). So update the code and comments to consider 6 units.
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/block-rsv.c')
| -rw-r--r-- | fs/btrfs/block-rsv.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/btrfs/block-rsv.c b/fs/btrfs/block-rsv.c index 90b8088e8fac..6edcb32ed4c9 100644 --- a/fs/btrfs/block-rsv.c +++ b/fs/btrfs/block-rsv.c @@ -350,14 +350,14 @@ void btrfs_update_global_block_rsv(struct btrfs_fs_info *fs_info) /* * But we also want to reserve enough space so we can do the fallback - * global reserve for an unlink, which is an additional 5 items (see the + * global reserve for an unlink, which is an additional 6 items (see the * comment in __unlink_start_trans for what we're modifying.) * * But we also need space for the delayed ref updates from the unlink, - * so its 10, 5 for the actual operation, and 5 for the delayed ref + * so its 12, 6 for the actual operation, and 6 for the delayed ref * updates. */ - min_items += 10; + min_items += 12; num_bytes = max_t(u64, num_bytes, btrfs_calc_insert_metadata_size(fs_info, min_items)); |