diff options
| author | Jeff Layton <jlayton@kernel.org> | 2023-06-15 08:49:45 -0400 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-06-19 17:38:50 +0200 |
| commit | c9e561c4753c8c561452393762b957241e74e820 (patch) | |
| tree | 5320b97ff53eac4b6b3fbd855aa233b8b64a42e6 /fs/btrfs/volumes.c | |
| parent | e794203e9d2d610faf6c5926345091193b202af5 (diff) | |
btrfs: update i_version in update_dev_time
When updating the ctime, we also want to update i_version.
This is just something I noticed by inspection. There is probably no way
to test this today unless you can somehow get to this inode via nfsd.
Still, I think it's the right thing to do for consistency's sake.
David Sterba's comment: I don't see anything wrong with setting the
iversion bit, however I also don't see where this would be useful.
Agreed with the consistency, otherwise the time is updated when device
super block is wiped or a device initialized, both are big events so
missing that due to lack of iversion update seems unlikely. I'll add it
to the queue, thanks.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
[ add comments ]
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/volumes.c')
| -rw-r--r-- | fs/btrfs/volumes.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 8137c04f31c9..b8540af6e136 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1928,7 +1928,7 @@ static void update_dev_time(const char *device_path) return; now = current_time(d_inode(path.dentry)); - inode_update_time(d_inode(path.dentry), &now, S_MTIME | S_CTIME); + inode_update_time(d_inode(path.dentry), &now, S_MTIME | S_CTIME | S_VERSION); path_put(&path); } |