diff options
| author | Jan Kara <jack@suse.cz> | 2017-04-05 13:32:52 +0200 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2017-04-05 14:23:45 +0200 |
| commit | 65547661500885dde26ca4a75d4d7f7df587c88e (patch) | |
| tree | 72f05ce433afc3249d1ec242679c4c04d041e9e2 /fs/ext2/inode.c | |
| parent | ab4949640d6674b617b314ad3c2c00353304bab9 (diff) | |
ext2: Call dquot_writeback_dquots() with s_umount held
ext2_sync_fs() could be called without s_umount semaphore held when
called through ext2_write_super() from __ext2_write_inode(). This
function then calls dquot_writeback_dquots() which relies on s_umount to
be held for protection against other quota operations.
In fact __ext2_write_inode() does not need all the functionality
ext2_write_super() provides. It is enough to just write the superblock.
So use ext2_sync_super() instead.
Fixes: 9d1ccbe70e0b14545caad12dc73adb3605447df0
Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext2/inode.c')
| -rw-r--r-- | fs/ext2/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 128cce540645..4d3e2528ac17 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -1615,7 +1615,7 @@ static int __ext2_write_inode(struct inode *inode, int do_sync) EXT2_SET_RO_COMPAT_FEATURE(sb, EXT2_FEATURE_RO_COMPAT_LARGE_FILE); spin_unlock(&EXT2_SB(sb)->s_lock); - ext2_write_super(sb); + ext2_sync_super(sb, EXT2_SB(sb)->s_es, 1); } } } |