diff options
author | Jan Kara <jack@suse.cz> | 2022-11-21 14:09:29 +0100 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2022-12-08 21:49:25 -0500 |
commit | b40ebaf63851b3a401b0dc9263843538f64f5ce6 (patch) | |
tree | 8c33b3f959c22976b465ef20881a51eecd51338e /fs/ext4/xattr_user.c | |
parent | 956510c0c7439e90b8103aaeaf4da92878c622f0 (diff) |
ext4: avoid BUG_ON when creating xattrs
Commit fb0a387dcdcd ("ext4: limit block allocations for indirect-block
files to < 2^32") added code to try to allocate xattr block with 32-bit
block number for indirect block based files on the grounds that these
files cannot use larger block numbers. It also added BUG_ON when
allocated block could not fit into 32 bits. This is however bogus
reasoning because xattr block is stored in inode->i_file_acl and
inode->i_file_acl_hi and as such even indirect block based files can
happily use full 48 bits for xattr block number. The proper handling
seems to be there basically since 64-bit block number support was added.
So remove the bogus limitation and BUG_ON.
Cc: Eric Sandeen <sandeen@redhat.com>
Fixes: fb0a387dcdcd ("ext4: limit block allocations for indirect-block files to < 2^32")
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221121130929.32031-1-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Diffstat (limited to 'fs/ext4/xattr_user.c')
0 files changed, 0 insertions, 0 deletions