summaryrefslogtreecommitdiff
path: root/fs/fuse
diff options
context:
space:
mode:
authorVasily Averin <vvs@virtuozzo.com>2020-06-25 12:39:51 +0300
committerMiklos Szeredi <mszeredi@redhat.com>2020-07-14 14:45:42 +0200
commit7779b047a57f6824a43d0e1f70de2741b7426b9d (patch)
treedfd3e39e7d3d39d92b3108dd44b9cfdd62b8625b /fs/fuse
parent6ddf3af93e32b996cfc30477ea1509960d4ba669 (diff)
fuse: don't ignore errors from fuse_writepages_fill()
fuse_writepages() ignores some errors taken from fuse_writepages_fill() I believe it is a bug: if .writepages is called with WB_SYNC_ALL it should either guarantee that all data was successfully saved or return error. Fixes: 26d614df1da9 ("fuse: Implement writepages callback") Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'fs/fuse')
-rw-r--r--fs/fuse/file.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index a6a5aeff258d..9895ce2d7023 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -2165,10 +2165,8 @@ static int fuse_writepages(struct address_space *mapping,
err = write_cache_pages(mapping, wbc, fuse_writepages_fill, &data);
if (data.wpa) {
- /* Ignore errors if we can write at least one page */
WARN_ON(!data.wpa->ia.ap.num_pages);
fuse_writepages_send(&data);
- err = 0;
}
if (data.ff)
fuse_file_put(data.ff, false, false);