diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2022-07-08 14:27:09 -0400 |
|---|---|---|
| committer | Chuck Lever <chuck.lever@oracle.com> | 2022-07-29 20:16:56 -0400 |
| commit | 427f5f83a3191cbf024c5aea6e5b601cdf88d895 (patch) | |
| tree | fdd97a04ea12d861ccf06dadd59f737845a74744 /fs/nfsd/filecache.h | |
| parent | 5e138c4a750dc140d881dab4a8804b094bbc08d2 (diff) | |
NFSD: Ensure nf_inode is never dereferenced
The documenting comment for struct nf_file states:
/*
* A representation of a file that has been opened by knfsd. These are hashed
* in the hashtable by inode pointer value. Note that this object doesn't
* hold a reference to the inode by itself, so the nf_inode pointer should
* never be dereferenced, only used for comparison.
*/
Replace the two existing dereferences to make the comment always
true.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'fs/nfsd/filecache.h')
| -rw-r--r-- | fs/nfsd/filecache.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/filecache.h b/fs/nfsd/filecache.h index 28145f162892..8e8c0c47d67d 100644 --- a/fs/nfsd/filecache.h +++ b/fs/nfsd/filecache.h @@ -39,7 +39,7 @@ struct nfsd_file { #define NFSD_FILE_PENDING (1) #define NFSD_FILE_REFERENCED (2) unsigned long nf_flags; - struct inode *nf_inode; + struct inode *nf_inode; /* don't deref */ refcount_t nf_ref; unsigned char nf_may; struct nfsd_file_mark *nf_mark; |